Skip to content

fix(canonical): copilot path + update parent #2901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
icecrasher321 merged 1 commit into from
Jan 20, 2026
Merged

fix(canonical): copilot path + update parent #2901

icecrasher321 merged 1 commit into from
Jan 20, 2026

Conversation

@icecrasher321
Copy link
Collaborator

@icecrasher321 icecrasher321 commented Jan 20, 2026

Summary

  • Canonical Modes being stripped on copilot edits
  • Update Parent had same issue
  • Must queue edge deletion on remove from subflow correctly

Type of Change

  • Bug fix

Testing

Tested manually

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel
Copy link

vercel bot commented Jan 20, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Review Updated (UTC)
docs Skipped Skipped Jan 20, 2026 5:39pm

Request Review

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 20, 2026

Greptile Summary

This PR fixes issues where block data properties (specifically canonicalModes) were being stripped during copilot edits and parent updates.

Key Changes:

  • Added canonicalModes field to the Zod schema in the state API route to prevent validation from stripping this property
  • Modified parent update logic in database operations to preserve all data properties except parentId and extent when removing from parent (previously cleared all data)
  • Added proper operation queueing for edge deletion when updating parent to ensure collaborative sync

Technical Details:
The root cause was that when removing a block from a subflow parent, the code was setting data: {} which cleared ALL properties including canonicalModes. The fix uses object destructuring to only remove parentId and extent while preserving other properties like canonicalModes, width, height, etc.

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • The changes are well-targeted bug fixes with clear intent. The destructuring pattern preserves existing data properties correctly, and the edge deletion queueing follows established patterns in the codebase. All changes maintain backward compatibility.
  • No files require special attention

Important Files Changed

Filename Overview
apps/sim/app/api/workflows/[id]/state/route.ts Added canonicalModes to BlockDataSchema to prevent stripping during state validation
apps/sim/hooks/use-collaborative-workflow.ts Added edge deletion queueing when updating parent to properly sync edge removal operations
apps/sim/socket/database/operations.ts Fixed data preservation by using destructuring to only remove parentId and extent when removing from parent, preserving other properties like canonicalModes

Sequence Diagram

sequenceDiagram
    participant Client
    participant API as State API
    participant Hook as useCollaborativeWorkflow
    participant Store as WorkflowStore
    participant Socket as Socket Operations
    participant DB as Database Operations

    Note over Client,DB: Copilot Edit Flow (preserving canonicalModes)
    Client->>API: PUT /api/workflows/[id]/state
    API->>API: Validate with BlockDataSchema<br/>(includes canonicalModes)
    API->>DB: Save workflow state
    DB->>DB: Preserve canonicalModes in block.data
    API-->>Client: Success

    Note over Client,DB: Update Parent Flow (edge cleanup)
    Client->>Hook: collaborativeBatchUpdateParent
    Hook->>Hook: Collect affected edges
    Hook->>Socket: Queue BATCH_REMOVE_EDGES operation
    Hook->>Store: batchRemoveEdges(edgeIds)
    Hook->>Socket: Queue BATCH_UPDATE_PARENT operation
    Hook->>Store: batchUpdateBlocksWithParent
    Socket->>DB: Persist edge removal
    Socket->>DB: Persist parent update
    DB->>DB: Destructure to remove only<br/>parentId & extent
    DB->>DB: Preserve canonicalModes & other data
    DB-->>Socket: Success
    Socket-->>Client: Sync to other clients
Loading

@icecrasher321 icecrasher321 merged commit 689037a into staging Jan 20, 2026
11 checks passed
@icecrasher321 icecrasher321 deleted the fix/canonical-modes-save branch January 20, 2026 17:43
@waleedlatif1 waleedlatif1 mentioned this pull request Jan 21, 2026
Merged
waleedlatif1 added a commit that referenced this pull request Jan 21, 2026
@waleedlatif1 @icecrasher321 @emir-karabeg
v0.5.65: gemini updates, textract integration, ui updates (#2909)
0ce0f98 
* fix(google): wrap primitive tool responses for Gemini API compatibility (#2900)

* fix(canonical): copilot path + update parent (#2901)

* fix(rss): add top-level title, link, pubDate fields to RSS trigger output (#2902)

* fix(rss): add top-level title, link, pubDate fields to RSS trigger output

* fix(imap): add top-level fields to IMAP trigger output

* improvement(browseruse): add profile id param (#2903)

* improvement(browseruse): add profile id param

* make request a stub since we have directExec

* improvement(executor): upgraded abort controller to handle aborts for loops and parallels (#2880)

* improvement(executor): upgraded abort controller to handle aborts for loops and parallels

* comments

* improvement(files): update execution for passing base64 strings (#2906)

* progress

* improvement(execution): update execution for passing base64 strings

* fix types

* cleanup comments

* path security vuln

* reject promise correctly

* fix redirect case

* remove proxy routes

* fix tests

* use ipaddr

* feat(tools): added textract, added v2 for mistral, updated tag dropdown (#2904)

* feat(tools): added textract

* cleanup

* ack pr comments

* reorder

* removed upload for textract async version

* fix additional fields dropdown in editor, update parser to leave validation to be done on the server

* added mistral v2, files v2, and finalized textract

* updated the rest of the old file patterns, updated mistral outputs for v2

* updated tag dropdown to parse non-operation fields as well

* updated extension finder

* cleanup

* added description for inputs to workflow

* use helper for internal route check

* fix tag dropdown merge conflict change

* remove duplicate code

---------

Co-authored-by: Vikhyath Mondreti <vikhyath@simstudio.ai>

* fix(ui): change add inputs button to match output selector (#2907)

* fix(canvas): removed invite to workspace from canvas popover (#2908)

* fix(canvas): removed invite to workspace

* removed unused props

* fix(copilot): legacy tool display names (#2911)

* fix(a2a): canonical merge  (#2912)

* fix canonical merge

* fix empty array case

* fix(change-detection): copilot diffs have extra field (#2913)

* improvement(logs): improved logs ui bugs, added subflow disable UI (#2910)

* improvement(logs): improved logs ui bugs, added subflow disable UI

* added duplicate to action bar for subflows

* feat(broadcast): email v0.5 (#2905)

---------

Co-authored-by: Vikhyath Mondreti <vikhyathvikku@gmail.com>
Co-authored-by: Vikhyath Mondreti <vikhyath@simstudio.ai>
Co-authored-by: Emir Karabeg <78010029+emir-karabeg@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@icecrasher321